Skip to content

[Event Hubs Client] Track Two (Credential Fix)#8786

Merged
jsquire merged 1 commit intoAzure:masterfrom
jsquire:eventhubs/credential-fix
Nov 14, 2019
Merged

[Event Hubs Client] Track Two (Credential Fix)#8786
jsquire merged 1 commit intoAzure:masterfrom
jsquire:eventhubs/credential-fix

Conversation

@jsquire
Copy link
Copy Markdown
Member

@jsquire jsquire commented Nov 14, 2019

Summary

The focus of these changes is to provide better synchronization for the shared access signature credential used for connection string-provided credentials to ensure that the signature and expiration date are in-sync when the expiration is extended.

Last Upstream Rebase

Thursday, November 14, 3:01pm (EST)

Related and Follow-Up Issues

@jsquire jsquire added Event Hubs Client This issue is related to a non-management package labels Nov 14, 2019
@jsquire jsquire self-assigned this Nov 14, 2019
@jsquire jsquire force-pushed the eventhubs/credential-fix branch from 92e41c4 to 8fcb605 Compare November 14, 2019 15:28
Copy link
Copy Markdown
Contributor

@kinelski kinelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread sdk/eventhub/Azure.Messaging.EventHubs/src/Authorization/SharedAccessSignature.cs Outdated
Comment thread sdk/eventhub/Azure.Messaging.EventHubs/src/Authorization/SharedAccessSignature.cs Outdated
The focus of these changes is to provide better synchronization for the shared
access signature credential used for connection string-provided credentials
to ensure that the signature and expiration date are in-sync when the
expiration is extended.
@jsquire jsquire force-pushed the eventhubs/credential-fix branch from 8fcb605 to f074330 Compare November 14, 2019 20:01
@jsquire jsquire merged commit 354d3d9 into Azure:master Nov 14, 2019
@jsquire jsquire deleted the eventhubs/credential-fix branch November 14, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue is related to a non-management package Event Hubs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants